fix: correct footer height calculation when bottom offset is applied#1503
Open
ParthAggarwal16 wants to merge 1 commit intointernetarchive:masterfrom
Open
fix: correct footer height calculation when bottom offset is applied#1503ParthAggarwal16 wants to merge 1 commit intointernetarchive:masterfrom
ParthAggarwal16 wants to merge 1 commit intointernetarchive:masterfrom
Conversation
Author
|
Hey @cdrini , can you take a look at this when you get the chance, thanks a lot ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR fixes an issue where the footer height calculation could be incorrect when a CSS bottom offset is applied, leading to layout and scrollbar issues
the logic has been simplified to consistently measure the footer element itself and safely account for its bottom offset, avoiding reliance on mode specific elements and guarding against missing refs
screen recording demonstrating the behaviour after the fix attached
Closes #1502
Screen.Recording.2026-01-30.at.1.54.15.PM.mov